search

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
43 stars 67 forks source link

[No Ticket] Don't Pass Empty Header #349

Closed NyanHelsing closed 6 years ago

NyanHelsing commented 6 years ago

Ticket

No ticket

Purpose

Tidies up the operation of a little bit of code.

Changes

The OSF provider was passing a header with an empty value, this change means the if the header is empty, then the header isn't sent at all.

This technically is a small optimization as well, it removes a few instructions that would get called inside aiohttp. if this header was here. (This is probably insignificant, however.)

Side effects

OSF gets no header in this situation now

QA Notes

Deployment Notes

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 71.218% when pulling f1d54f5a17c7e440fa9a560bd12181d39fcc64e5 on birdbrained:ft/improve-metadata-headers into d15d3224c522958d63ea8470c55879e53fa2176f on CenterForOpenScience:develop.