CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
44 stars 67 forks source link

[HotFix] [SVCS-918] Use White Background For Zoomed Images #351

Closed cslzchen closed 5 years ago

cslzchen commented 6 years ago

Ticket

https://openscience.atlassian.net/browse/SVCS-918

Purpose

cc and h/t @Johnetordoff for discovering this

Fix the issue where zooming does not work properly for .GIFs with transparent background. Here is the example on staging OSF. This bug only affects non-exported types: .GIF and .ICO. For exported ones, the export type .JPEG does not have transparency so the background is set to white by default.

Normal

normal

Zoom - Before

zoom

Changes

Zoom - After

zoom-fixed

Side effects

No

QA Notes

Test that image rendering and zooming works as expected.

Deployment Notes

No

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 71.117% when pulling 4ba1f1a447fe915bedd3253968994d7c8abc43a5 on cslzchen:hotfix/image-zoom-gif into ead3389dd0363333778ab53fc2c64211a141c90c on CenterForOpenScience:develop.