search

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
43 stars 67 forks source link

Handle newer jasp files #371

Closed JorisGoosen closed 9 months ago

JorisGoosen commented 9 months ago

Purpose

JASP files have been updated recently and could no longer be previewed on OSF.

Changes

This PR removes some superfluous check that allow the file renderer to show both old and new jasp-files.

Problems

Me and my colleague @rensdofferhoff tried running the tests and renderer locally to test this. But the versions request are all ancient and we could not get test to fail and this detected.

In other words, this is untested but we have no idea how to get it tested. The changes are rather minimal though so it should just work.

JorisGoosen commented 9 months ago

Ah @rensdofferhoff is asking me to open and close this repeatedly. Ill just close it for now.

But testing changes to this repository is not trivial it seems