search

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
44 stars 67 forks source link

Handle newer jasp files #372

Closed RensDofferhoff closed 11 months ago

RensDofferhoff commented 12 months ago

Purpose

JASP files have been updated recently and could no longer be previewed on OSF.

Changes

This PR removes some superfluous check that allow the file renderer to show both old and new jasp-files. A new test case is added for newer files.

RensDofferhoff commented 11 months ago

Any chance this could be merged quickly? Anything we need to add/change to comply?

felliott commented 11 months ago

Would there be any drawback to using the same approach as the jamovi PR? I'm prepping a release for that, and it seems like they might be similar. I'd kinda like to keep the extra validation, since a lot of file types are renamed zip files.

I will test it locally with the jamovi fix (adding a check for the new manifest name), but is there anything else that I should be concerned about? Thank you!

felliott commented 11 months ago

The exact fix didn't work since the format of the manifest changed. I've adapted it a bit to still do some basic validation. This is merged into develop and I will cut a release early next week (post-new-years).

felliott commented 11 months ago

This has been released!

JorisGoosen commented 11 months ago

It works great, merci