search

CenterForOpenScience / osf-style

Stylesheet and guidelines for OSF
https://centerforopenscience.github.io/osf-style/
Apache License 2.0
3 stars 26 forks source link

[OSF-8228] style-side Navbar cleanup (firefox username alignment, long username fix) #102

Closed Johnetordoff closed 7 years ago

Johnetordoff commented 7 years ago

Purpose

Current there are two problems with the OSF navbar:

  1. The username name text and gravtar are silghtly out of vertical alignment
  2. Very long usernames (even though they are wrapped properly) can break the navbar into two unsightly rows. Alignment problem: screen shot 2017-07-05 at 3 19 15 pm Row problem: screen shot 2017-07-05 at 3 24 23 pm

Changes

Simple CSS and HTML changes, now the navbar will collapse into a dropdown sooner and the alignment is fixed with style tags.

Side effects

Should be limited to aesthetics. I used style tags where possible to avoid any unforeseeable interaction.

Tests

For aesthetics changes I can't think of any meaningful tests.

Ticket

https://openscience.atlassian.net/browse/OSF-8228

brianjgeiger commented 7 years ago

@caneruguz Could you review, please?

caneruguz commented 7 years ago

@Johnetordoff you mention html changes, which would not be in this repo because it deals with css only, so they are likely in OSF right? Just making sure.

Johnetordoff commented 7 years ago

Yep, css only