The sign-up button on the ember-osf-web navbar is shorter than the login button:
This PR gives the sign-up button the same line-height as the login button, so they will look the same.
It was confusing why this was only the case for ember-osf-web, not for the legacy UI or our other ember apps. Turns out, they set line-height explicitly, hiding the error in osf-style:
ember-osf does it in the old, unusedosf-navbar component. Because ember-osf doesn't use ember-component-css, the component stylesheet is at the global scope, so the old navbar's stylesheet applies to the new navbar, too.
The sign-up button on the ember-osf-web navbar is shorter than the login button:
This PR gives the sign-up button the same
line-heightas the login button, so they will look the same.It was confusing why this was only the case for ember-osf-web, not for the legacy UI or our other ember apps. Turns out, they set
line-heightexplicitly, hiding the error in osf-style:osf-navbarcomponent. Because ember-osf doesn't use ember-component-css, the component stylesheet is at the global scope, so the old navbar's stylesheet applies to the new navbar, too.