search

CenterForOpenScience / osf-style

Stylesheet and guidelines for OSF
https://centerforopenscience.github.io/osf-style/
Apache License 2.0
3 stars 26 forks source link

Suggestion: Do not disable Submit buttons if input is invalid #32

Closed sloria closed 9 years ago

sloria commented 9 years ago

This has been discussed here: https://github.com/CenterForOpenScience/osf.io/issues/1035 . I recommend adding a guideline that says not to disable form submit buttons if data are invalid. Instead, the user should be allowed to click submit and see error messages next to the bad input.

caneruguz commented 9 years ago

I added it to here with state of submit buttons. http://caneruguz.github.io/osf-style/ui.html#button-state

sloria commented 9 years ago

Thanks for adding that. I find the examples slightly misleading--they appear to suggest that you should display validation messages next to the buttons when they should be displayed next to or under the input elements.

sloria commented 9 years ago

Also, just to clarify:

osf_style___ui_guidelines

Is this suggesting that the Save button is disabled only when there is no user input yet, and that it will be enabled when there is user input (which may or may not be invalid)?