search

CenterForOpenScience / osf-style

Stylesheet and guidelines for OSF
https://centerforopenscience.github.io/osf-style/
Apache License 2.0
3 stars 26 forks source link

Add "Apply" to the button color section #52

Closed NatashaRichter closed 9 years ago

NatashaRichter commented 9 years ago

In the style guide, "Apply" is referred to in the chart below. However, it is not included in the button section where button colors are specified. Assigning it a color (blue?) in the chart will be clearer. Also, the chart says that it should be used for applying settings, like for add-ons. However, up till now, we've had green Submit buttons in add-on sections. To be consistent, we should decide on a color (otherwise, going with a green "Save" makes sense for add-on settings).

applybutton

buttoncolors

NatashaRichter commented 9 years ago

I see that there's now a green "Apply" for add-on settings. Thanks @haoyuchen1992 Perhaps we can still add the button to the color chart. Otherwise, looking good now!

caneruguz commented 9 years ago

Changed here: https://github.com/CenterForOpenScience/osf-style/commit/04947cc09f8d307a6127f3c2a899087a9a6c9059