search

CenterForOpenScience / osf-style

Stylesheet and guidelines for OSF
https://centerforopenscience.github.io/osf-style/
Apache License 2.0
3 stars 26 forks source link

Button text inconsistancies #69

Closed laurenrevere closed 9 years ago

laurenrevere commented 9 years ago

Steps

  1. Go to the settings page.
  2. See that some buttons are sentence case and some are title case.

screen shot 2015-07-28 at 8 59 33 am screen shot 2015-07-28 at 8 59 41 am

Expected

All buttons would have the same case.

Reality

Currently buttons have inconsistent cases and there is no explicit rule in the style guide.

Originally I believed that buttons should be title case (currently most of our buttons are), but @sloria brought up some good points here: https://github.com/CenterForOpenScience/osf.io/pull/3830#issuecomment-125313280

And here is another discussion of this issue: http://ux.stackexchange.com/questions/28297/should-we-use-title-case-or-sentence-case-for-headlines-and-buttons

Should buttons be title or sentence case? I believe most other button text issues are already handled in the style guide, but if there are any comments on that feel free to bring them up here!

laurenrevere commented 9 years ago

@natasharichter, @caileyfitz, @lbanner :)

caileyfitz commented 9 years ago

@geeksnglitter Hm... This is tricky. I definitely agree that the case should be consistent, whether it is title case or sentence case. I think that sentence case is the more acceptable usage here (mostly because that's what GitHub and Dropbox do), so I vote for sentence case. It can also sometimes be hard to know what needs to be capitalized in title case, so sentence casing all buttons removes that extra difficulty.

NatashaRichter commented 9 years ago

@geeksnglitter I agree with @caileyfitz. I like sentence case in buttons. Her reasons stated above are good. We'll also need to think about links. In some cases, links are all lower case and some cases sentence case, but I can create a separate issue for that.

laurenrevere commented 9 years ago

Side note: Google's main buttons are title case. screen shot 2015-07-28 at 10 44 30 am

We can follow github's lead and make buttons sentence case, but that means we should probably change a lot of other things on the OSF to be sentence case, such as the links @NatashaRichter mentioned. I will make another issue about general site capitalization soon.

If we decide to make most things on the OSF sentence case, there will be a lot to change.

caneruguz commented 9 years ago

Well @sloria is bringing up examples but they are not indicative of convention I think, there still seems to be discussion on that topic. However his solution is something I would support as well.

When we can we should try to justify these decisions with some good use reasons. The most compelling I have heard in these discussions so far is that "Sentence case" allows for better readibility since the capitalization continues as single case and does not need to be interpreted as separation of words. Title case does not seem to have an overwhelming advantage and may create more questions as stated here.

I vote we do sentence case and move on to make this a rule for Buttons and stand alone links. Links within sentences should follow whatever that sentence structure is.

caneruguz commented 9 years ago

Closing as part of this issue: https://github.com/CenterForOpenScience/osf-style/issues/71