CenterForOpenScience / osf-style

Stylesheet and guidelines for OSF

https://centerforopenscience.github.io/osf-style/

Apache License 2.0

3 stars 26 forks source link

Feature/New Navbar Styling [EOSF-618] #95

Closed pattisdr closed 7 years ago

pattisdr commented 7 years ago

Ticket

https://openscience.atlassian.net/browse/EOSF-618

Purpose

The OSF Navbar has been redesigned and implemented as a resuable Ember-OSF component that can be shared among our Ember applications. The navbar will need to be implemented separately OSF-side. Styles should be moved to OSF-style so they can be shared among our products.

Changes

Moves styles from Ember-OSF navbar widget to style guide.

pattisdr commented 7 years ago

@sloria, why did you close this? Do I need to make a new PR?

sloria commented 7 years ago

@pattisdr Sorry about that. I removed the develop branch, which closed all PRs targeting it. I've changed the base to master and reopened.

pattisdr commented 7 years ago

I see, thanks!

caneruguz commented 7 years ago

@pattisdr Looks good to me. Thanks for commenting and using SASS features.