search

CenterForOpenScience / osf.io

Facilitating Open Science
https://osf.io
Apache License 2.0
668 stars 329 forks source link

In anonymized view-only link, GitHub information is not anonymized #10717

Open umhan35 opened 1 month ago

umhan35 commented 1 month ago

What you did (step by step)

  1. Connect GitHub to a project
  2. Create a view-only link to share the OSF project (check off "Anonymize contributor list for this link (e.g., for blind peer review)")
  3. Go to the view-only link

Where does this happen on the OSF?

Anonymized view-only homepage of a project, e.g., https://osf.io/ga9w8/?view_only=3ec356c101944ec092c6badfbb0fb593

What you expected

The open button should not appear for people to go to the GitHub link

image

What actually happened

One can click the open button and find out information about the contributors of the OSF repo

Potential causes

Related code that may have caused this:

https://github.com/CenterForOpenScience/osf.io/blob/3920a29ff5c92a45229e618931661cc5d0c8a08d/addons/github/static/githubFangornConfig.js#L283-L291

Suggest a solution

Similar to the hidden GitHub repo (username/repo-name) in a view-only link, as seen below, the Open button should also be hidden.

Not view-only View-only
image image

Final words

I think the branch list should also be hidden in a view-only link