CenterForOpenScience / osf.io

Facilitating Open Science
https://osf.io
Apache License 2.0
676 stars 331 forks source link

[Onboard]File uploads dont work in IE 11 #1232

Closed kushG closed 9 years ago

kushG commented 10 years ago

Steps

1.Go to the project dashboard page.

  1. Drag a file from your system to the Upload File section(just below Drop File(or click below))

Expected

File should have been uploaded to your project.

Actual

Opens up File Download wizard for the file you're actually trying to upload. Note : Clicking on Drop File(or click below) wont show File upload wizard either leaving no option to upload files if you're using IE. gh issue

brianjgeiger commented 10 years ago

When doing browser-specific things, please include exact browser/OS versions. For JS stuff, please check your JS Error console for any errors that might be helpful. Thanks!

kushG commented 10 years ago

The version is IE 11. I don't have ad Blocker in my browser so apart from blocked ad errors I don't see any other error in console.

icereval commented 9 years ago

This appears to be an issue with Knockout Components and Dropzone. Stepping through the Dropzone source it adds many event callbacks to the specified DIV element, one of them being a passthrough 'onclick' event for the hidden file upload input widget. I was able to observe the events are never attached to the Dropzone DIV element when using IE 11.

Moving the Dropzone DIV out of the Knockout Component appears to be one possible workaround, however I was unable to find the root cause of the interaction between the two.

brianjgeiger commented 9 years ago

It's only vaguely related, and I don't know the underlying issues enough to know if this is at all useful, but JQuery Sortable has a problem with knockout where there has to be a min-height set on the element for it to work if it's in Knockout scope.

kmjungersen commented 9 years ago

Just as a heads up, I'm still seeing this issue in IE, on both production and staging with no errors in the console.

nanchen47 commented 9 years ago

same issue as https://github.com/CenterForOpenScience/osf.io/issues/1669