search

CenterForOpenScience / osf.io

Facilitating Open Science
https://osf.io
Apache License 2.0
666 stars 327 forks source link

[2factor]the warning message doesn't update properly #2385

Closed chennan47 closed 8 years ago

chennan47 commented 9 years ago

Current behavior:

1st issue When user clicks to enable 2-factor, there is an incorrect success message. This message should not appear until after the user successful enters their verification code.

2nd issue: After entering the verification code, the user does not get a success message within the form (when they should).

3rd issue: Status messages appearing at the top of the screen are not needed and should be removed.

Specification for the fix:

  1. When user clicks to enable 2-factor, they should be taken to the two factor security form. The form should have: the description of the process the QR code a box to put in the code user receives No status/success message should appear on this step.
  2. After the user enters the security code, a success message should appear in the form. *the message reads: "You have successfully enabled two-factor authentication"
  3. No status messages should appear at the top of the screen.

For testing:

Double check deactivation with this change (in addition to testing the above): When you deactivate, user sees a modal confirming deactivation (no change here just verify it still works). User should see no status message at the top of the page or in the form. The link changes to Enable two-factor authentication.

Documentation of former issues:

Steps

  1. log in to osf
  2. go to your user settings page
  3. enable two factor addon and don't authorize it yet then you will see on top: screen shot 2015-04-02 at 10 38 55 am cilck on the active your device link will redirect you to screen shot 2015-04-02 at 10 38 47 am
  4. authorize the two factor addon you will see the two factor filed becomes screen shot 2015-04-02 at 10 42 46 am but the warning message on top is still screen shot 2015-04-02 at 10 38 55 am

and click on the link doesn't take you anywhere.

Expected The warning message on top should be changed to "Your two factor addon has been successfully authorized".

MPNussbaum commented 9 years ago

@chennan47 @GaryKriebel Was not able to recreate.

screen shot 2015-05-19 at 6 30 40 pm screen shot 2015-05-19 at 6 31 07 pm

chennan47 commented 9 years ago

The problem is that, if you don't click to dismiss the message. It persist even you active the addon.

zkraime commented 9 years ago

@GaryKriebel I'll grab this one real quick