CenterForOpenScience / osf.io

Facilitating Open Science
https://osf.io
Apache License 2.0
669 stars 329 forks source link

Feature request: Support RFC-6266 for Download contents filename #8980

Open ebijun opened 5 years ago

ebijun commented 5 years ago

On contents file download,osf.io set the filename in content-disposition header.

like response['Content-Disposition'] = 'attachment; filename={}'.format(filename)

6 code results in osf.io https://github.com/CenterForOpenScience/osf.io/search?utf8=✓&q=Content-Disposition%3A&type=

If osf.io supports RFC-6266,download-filename containing the Unicode character can treat well.

see: https://tools.ietf.org/html/rfc6266#section-5

saradbowman commented 5 years ago

Hi @ebijun, Thanks for the heads up! The only public-facing API route affected by this hasn't been exposed in the UI yet, but we've ticketed it in our internal issue tracker to make sure it's fixed before it is exposed in the UI.