search

CenterForOpenScience / waterbutler

WaterButler is a Python web application for interacting with various file storage services via a single RESTful API, developed at Center for Open Science.
Apache License 2.0
62 stars 76 forks source link

os.path.join creates malformed URLs on Windows #373

Open BenediktHeinrichs opened 5 years ago

BenediktHeinrichs commented 5 years ago

We are currently trying to run waterbutler on Windows and on inspection of the registered routes, we stumbled upon the following line in app.py:

(os.path.join('/', api.PREFIX, pattern.lstrip('/')), handler)

This has a strange behavior on Windows, so that instead of a normal "/" it adds a "\", which makes the api v1 not useable on Windows.

One workaround we implemented was to just add those three strings manually using the following line:

('/' + api.PREFIX + '/' + pattern.lstrip('/'), handler)