Closed cslzchen closed 4 years ago
As discussed in person, the new test failures caused by base image update merged will be / has been fixed along with CR by @felliott . Given that I have rebased the PR, we may need to manually commit-close this PR during merge.
Ticket
https://openscience.atlassian.net/browse/ENG-335
Purpose
Enable and update the Google Drive provider for
aiohttp3
.Changes
async with ... as resp: ...
intoresp = await ...
.Side effects
No
QA Notes
Below is a list of what I have tested locally according to the list provided by the ticket. Surprisingly, everything works as expected.
As usual, 1) files tested are of five different sizes: 20B, 1.4MB, 11MB, 88MB and 264MB, 2) intra-move-copy are tested between two components connected to the same Google account, one component is the Drive root and the other is a Drive folder, and 3) no comments indicates a PASS for each item.
Getting metadata for a file / folder: tested along with file view and folder listing
Downloading
Uploading (both to the root and a subfolder
DAZ
Deletion
Folder
Rename
Verifying non-root folder access for id-based folders: N / A
Intra move/copy
Inter move/copy (light testing only)
Comments persist with moves (light testing only)
Revisions: enabled and tested
Project root is storage root vs. a subfolder: N / A but tested anyway given I need two components for testing intra-move-and-copy
Updating a file: tested along with Revisions
Deployment Notes
No