search

CenterForTheBuiltEnvironment / ashrae-db-II

18 stars 6 forks source link

Columns have mixed types #1

Closed FedericoTartarini closed 2 years ago

FedericoTartarini commented 2 years ago

The following columns have mixed datatypes: 'subject_id' (float, int, str), 'air_movement_acceptability' (float, str), 'air_movement_preference' (float, str).

We should fix that since Python throws an error. Moreover, I guess we can assign an arbitrary ID to all participants, even to those who currently do not have one, since it is just an incremental integer as far as I can see.

tom-parkinson commented 2 years ago

'subject_id' depends on decision in #6 . I've fixed the other two.

tom-parkinson commented 2 years ago

I like your suggestion of assigning subject_id where we just assume they are unique for each building

FedericoTartarini commented 2 years ago

Let's assume for now that subject_id were unique for each building. In future we will request this information.

tom-parkinson commented 2 years ago

I'm walking back on the idea of retrospectively adding subject_id to datasets that don't have it. I'll keep the column for future studies and marking presently missing values as such.

FedericoTartarini commented 2 years ago

okay, I understand your concern and I am happy with your decision

FedericoTartarini commented 2 years ago

This issue is not fully solved. I will take care of it.