translate the example_acm R code to Python code

CenterForTheBuiltEnvironment / ashrae-db-II

18 stars 6 forks source link

translate the example_acm R code to Python code #24

Closed ruijis closed 1 year ago

ruijis commented 1 year ago

executing the example_acm.py will generate a png file in the current folder. (required packages need to be installed, which are specified in the environment. yml)
Or you can try the online Jupiter notebook through Binder (just click the logo). It will automatically configure the environment for you.
The plot and regression results are 99% similar to R code, not 100% due to computation stability I guess.

ruijis commented 1 year ago

Hi Federico, would you like to check the python file? @FedericoTartarini

FedericoTartarini commented 1 year ago

Hi @ruijis I am a bit flat out at the moment with work and I will not have much time to review it. Please let me know if there is some specific lines you would like me to review otherwise i trust that you did a good job.

ruijis commented 1 year ago

Hi @ruijis I am a bit flat out at the moment with work and I will not have much time to review it. Please let me know if there is some specific lines you would like me to review otherwise i trust that you did a good job.

Thank you. @tom-parkinson, would you like just to run the Python file on your computer and see if the adaptive model graph is the same as yours from the R code? Or you can run the Jupyternotebook which has the same code.

tom-parkinson commented 1 year ago

Looks good so I've merged it. Thanks @ruijis for your work on this ❤️