CenterForTheBuiltEnvironment / clima

The CBE Clima Tool is a web-based application built to support the need of architects and engineers interested in climate-adapted design. It allows users to analyze the climate data of more than 27,500 locations worldwide using the data contained in EPW files.
https://clima.cbe.berkeley.edu
MIT License
61 stars 21 forks source link

Inconsistent filtering behaviour in Outdoor comfort tab (1/2) #183

Closed giobetti closed 1 year ago

giobetti commented 1 year ago

Describe the bug

not a bug per se, but the wrong behaviour has been implemented

The way the Otdoor comfort tab filters data is visually inconsistent with the way the same filtering is done in other tabs (i.e. natural ventilation) See images below for the same filter set image wrong 👇 image

correct 👇 image

Please keep the behaviour consistent

Furthermore, the filtering doesn't affect the bar chart at the bottom, see issue #184

phuongdoan13 commented 1 year ago

Hi Giobetti, thank you for your feedback.

As fas as I can see, there are two things that I need to update: 1) I should have a description paragraph to describe the current filter. 2) I still should show all the months, but with the filtered data.

Could you please confirm if I am understanding correctly?

FedericoTartarini commented 1 year ago

Yes, this is correct. Please implement those two changes.