CenterForTheBuiltEnvironment / clima

The CBE Clima Tool is a web-based application built to support the need of architects and engineers interested in climate-adapted design. It allows users to analyze the climate data of more than 27,500 locations worldwide using the data contained in EPW files.
https://clima.cbe.berkeley.edu
MIT License
61 stars 21 forks source link

Confirm that Docker dependencies match Pipfile #209

Closed mccalluc closed 1 year ago

mccalluc commented 1 year ago

Is your feature request related to a problem? Please describe. This may be paranoid, but it seems like local developers will get the dependencies in the Pipfile, but nothing checks that this is in sync with the requirements.txt referenced by Dockerfile.

Describe the solution you'd like Lean towards simplifying things, and referencing Pipfile directly from Dockerfile.

Describe alternatives you've considered Alternatively, check that the requirements.txt is up to date -- Something like:

diff -y <( pipenv run pip freeze ) requirements.txt

Or the new Cypress test could run build the Docker container... That would be a real check of the production build.

Additional context none

FedericoTartarini commented 1 year ago

I like the first solution

referencing Pipfile directly from Dockerfile

We should then be able to remove the requirements.txt file since we can generate it inside Docker