CenterForTheBuiltEnvironment / comfort-dash

Revision of the CBE Comfort Tool using Dash.
0 stars 12 forks source link

Custome Ensemble & Adjust Footer #34

Closed Ruixin126 closed 5 days ago

Ruixin126 commented 1 week ago

Custome ensemble and adjust footer modification

Description

Base on the issues #6 The footer has been redesigned to the PC and mobile platform. And fix a bug when user select clothing value exceed 1.5 there are will be a warning. and add clothing value to the every selection.

Types of change

Here is the PC version of the CBE tool image

Here is the mobile version of the CBE tool image

Compare to the issues from Toby image

Warning for Custom Ensemble if exceed 1.5 clo value image

add clothing vlaue to every selection image

Add more charts slection from back-end require image

Checklists

FedericoTartarini commented 1 week ago

Thank you for working on this, however, @Ruixin126 you are addressing two issues here, and these should have been submitted as two separate pull requests:

  1. Footer
  2. Custom Ensemble.

I will review the code and if everything looks good I will merge it to main but in the future please submit separate pull requests.

Ruixin126 commented 1 week ago

This for update the max value for different model: e77c627c073645573c89cff77c2035c

FIx the error for model names: 16546703480aadacd5f5e1b806367ec

Fix the error the links should follow the previous line: 79307b6cbfe4b839d9842d6547ea03e

Hi, Please check again.

FedericoTartarini commented 5 days ago

@Ruixin126 please address my comments today before lunch time so I can accept your Pull request

Ruixin126 commented 5 days ago

It's look like all comments has been resolved.

FedericoTartarini commented 5 days ago

@Ruixin126 please address my comments and please follow my intructions in the future. I am honestly very tired of having to repeat the same conecpts

Ruixin126 commented 5 days ago

@FedericoTartarini Could you please point out which comments haven't address?

FedericoTartarini commented 5 days ago

@Ruixin126 just check the pending comments in this pull request, I commented the code

Ruixin126 commented 5 days ago

I haven't seen any comment haven't marked as unresolved

FedericoTartarini commented 5 days ago

all these, just scroll up

image
Ruixin126 commented 5 days ago

I've fix the error like this, and removed the import image by the way, I still can't see the unresolved comment, this might be a GitHub issue. image