Closed Ruixin126 closed 5 days ago
Thank you for working on this, however, @Ruixin126 you are addressing two issues here, and these should have been submitted as two separate pull requests:
I will review the code and if everything looks good I will merge it to main but in the future please submit separate pull requests.
This for update the max value for different model:
FIx the error for model names:
Fix the error the links should follow the previous line:
Hi, Please check again.
@Ruixin126 please address my comments today before lunch time so I can accept your Pull request
It's look like all comments has been resolved.
@Ruixin126 please address my comments and please follow my intructions in the future. I am honestly very tired of having to repeat the same conecpts
@FedericoTartarini Could you please point out which comments haven't address?
@Ruixin126 just check the pending comments in this pull request, I commented the code
I haven't seen any comment haven't marked as unresolved
all these, just scroll up
I've fix the error like this, and removed the import by the way, I still can't see the unresolved comment, this might be a GitHub issue.
Custome ensemble and adjust footer modification
Description
Base on the issues #6 The footer has been redesigned to the PC and mobile platform. And fix a bug when user select clothing value exceed 1.5 there are will be a warning. and add clothing value to the every selection.
Types of change
Implementation
Here is the PC version of the CBE tool
Here is the mobile version of the CBE tool
Compare to the issues from Toby
Warning for Custom Ensemble if exceed 1.5 clo value
add clothing vlaue to every selection
Add more charts slection from back-end require
Checklists