CenterForTheBuiltEnvironment / comfort-dash

Revision of the CBE Comfort Tool using Dash.
0 stars 12 forks source link

Develop ideas for main UI plots #4

Open t-kramer opened 1 month ago

t-kramer commented 1 month ago

For the new version of the Comfort Tool, we want to include most functions/models listed here. This will go far beyond the current capabilities, which means that we also need to think about plots visualizing the results of the newly introduced functions in the main UI.

Go through the listed functions and develop ideas for visuals, ideally using Plotly.

t-kramer commented 4 weeks ago

Ready to go, @black6pepper @Yannnnnnny

Yannnnnnny commented 3 weeks ago

I saw that you defined an example in ‘charts.py’. Now we have made a visualization of 'adaptive ASHAREA' case. I don't know where we should upload it.

t-kramer commented 3 weeks ago

@Yannnnnnny Open a branch for this issue and add your chart to the charts.py module. Before you submit a pull request, please share a screenshot of the visualization here, so I can take a look.

Alternatively, since you'll be developing and testing more charts, you can also create a notebook (on the new branch) for all of them and add the newly developed plots to the charts module whenever we think they are ready.

FedericoTartarini commented 3 weeks ago

@Yannnnnnny I like the suggestion of creating a notebook in which you can show us all the charts you are working on, this will enable you to focus on the chart code and not on the Dash code. Moreover it will enable us to quickly review your work and will create less merge errors.

Yannnnnnny commented 3 weeks ago

thanks for your suggestion, I will create a notebook for visualization.

Yannnnnnny commented 3 weeks ago

sorry to bother you, we haven't find the mature chart model in plotly for Psychrometric Chart, can we use other libraries? if we can't, could we use numpy help to draw the chart? WechatIMG207

FedericoTartarini commented 3 weeks ago

You can recreate the chart simply by plotting lines as we did in the CBE Clima too. The clima tool code is here. However, do not simply copy and paste the code since we need to simplify it.

Yannnnnnny commented 3 weeks ago

thank you!!

FedericoTartarini commented 3 weeks ago

very happy to help :), but please in future no need to write thank you so we can reduce the number of notifications all the team members in this issue receive.

black6pepper commented 1 week ago

i been made a few visualization and i wanna hear some advice from you firstly is the adaptive method of EN 16798 The one on the left is the one I made and the one on the right is the original image.

23bbed795e63ed18ec73b19d653f624

Then there's the psychrometric char of EN-16798. image I drew this picture and added a different hover function to show the value of the current point when the mouse moves to a certain place. it followed by my comparison chart image Could you please give me a little advice so that I can do a better job? thank you very much

t-kramer commented 1 week ago

@black6pepper That's a good start. The adaptive chart looks very much like we want it to be and with some minor tweaks (font sizes, alpha values, layout, etc.) it'll be fine. For the psychrometric chart, you should try to get closer to the template from the original tool. Do you have any particular problems creating the psychrometric chart?

Also, I'd like to see the code and provide more detailed comments there. Can you share it in the repository? Ideally we use notebooks until we are satisfied with the chart.

FedericoTartarini commented 1 week ago

I agree with all the comments from Toby. @black6pepper This is a very good start, however, we need to make sure that the layout of the charts is consistent, for exmaple:

Sometimes the chart in the CBE thermal comfort tool are not perfect and need to be improved, hence, before recreating them please have a quick chat with me and @t-kramer. Please also share the code with us and not just screenshots. I am very happy to see some progress on this.

t-kramer commented 1 week ago

@black6pepper @Yannnnnnny Can you please start sharing your ideas for the plots using a notebook? I'd like to help you, but need to see the code.