Jinjia-Bai
commented
3 days ago I reviewed your work and I think you may need to add a unit judgment to control the unit of inputs. And, I am not sure whether you should add 'limit_inputs=False' parameter in adaptive_ashrae function to make sure it still can output values if input values are outside the applicability limits of the model.
Description
The image calculation part of adaptive_ashrae Adaptive chart is basically completed.
Type of change
How Has This Been Tested?
Test：I wrote a rough visual drawing code (this part of the work should be for the front end visualization members, after you have reviewed lines 119 -151 of my calculation in charts.py file, the front end members can improve the visualization) to look at the image and check that the edge areas of the image are calculated correctly.
Remaining issues
I'm not sure if the input part of the data in lines 121 -130 of the charts.py file is canonical? Does it meet your requirements? (In fact, there is already input code in line 62-67 of the show_results.py file, I wonder if I can call it directly to avoid code duplication?)
I'm not sure how to calculate the input value operative_temperature in line 128 of the charts.py file? There is currently no 'use operative temp' check box on the front end, so I'll assume it equals (air_temperature + mean_radiant_temp) / 2.
Lines 153-207 of the charts.py file are the initial rough visualizations that I wrote to test whether the edges of my own graphics were calculated correctly. If you agree to merge other parts of my code, lines 153-207 will then be replaced with the front end dedicated to the visualization of the members (their visualization code may be more perfect).