CenterForTheBuiltEnvironment / pythermalcomfort

Package to calculate several thermal comfort indices (e.g. PMV, PPD, SET, adaptive) and convert physical variables.

https://pythermalcomfort.readthedocs.io/en/latest/

MIT License

140 stars 52 forks source link

pmvpdd differences in Py and R. #117

Open number9527-12 opened 1 week ago

number9527-12 commented 1 week ago

Describe the bug Her are the differences we have identified

[ ] calculation of xf
[ ] calculation of tcla

xf

In py the function is link xf = t_cla / 50 in R is link xf <- xn

tcla

py t_cla = taa + (35.5 - tdb) / (3.5 * icl + 0.1) r tclA <- taa + (35.5-ta) / (3.5 * (6.45 * icl + .1))

@FedericoTartarini and marcel to review

FedericoTartarini commented 1 week ago

In the ISO 7730 the equations are

but in the ASHRAE 55

Consequently the equation in R for tcla seems to be incorrect. Marcel what do you think about the xf?

marcelschweiker commented 6 days ago

Interesting to see the differences for XF between ISO 7730 and ASHRAE 55. I have no explanation for these. As for tcla, in the ISO 7730 version, I have (2005 version + unpublished 2023 draft) it is so in this case R would be correct. In any case, I would not expect too big differences in outcome as this line of code only affects the first guess for the surface temperature of the clothing, which will then be adjusted in iterations in the following loop and should result in the same value after the loop?

FedericoTartarini commented 6 days ago

@marcelschweiker great now I can tag you in the issues.