search

CenterForTheBuiltEnvironment / pythermalcomfort

Package to calculate several thermal comfort indices (e.g. PMV, PPD, SET, adaptive) and convert physical variables.
https://pythermalcomfort.readthedocs.io/en/latest/
MIT License
144 stars 52 forks source link

Difference between function calctAdaptASHRAE in the file calcAcomf.R and function adaptive_ashrae.py #140

Open LeylayqZhang opened 3 weeks ago

LeylayqZhang commented 3 weeks ago

The formula for calculating t_cmf in adaptive_ashrae.py is t_cmf = 0.31 t_running_mean + 17.8, while the formula for calculating tAdaptASHRAE in calcAcomf.R is tAdaptASHRAE = 0.33tmmo + 17.8, making the first 8 tests failing. The coefficient in those two equation should be the same, either 0.31 or 0.33. Also, the last 2 tests in test_calctAdaptASHRAE.R failed because calcAcomf.R didn't set the valid range (10.0, 33.5) for the input as the line 152 in adaptive_ashrae.py.

FedericoTartarini commented 3 weeks ago

@marcelschweiker in the ASHRAE 55 2023 the equation uses 0.31 as regression coefficient. May I ask you why you are using 0.33? Are you using another document as a reference? What range did you use, the ASHRAE 55 2023 specifies that the model is only applicable between 10 and 33.5

image

image

marcelschweiker commented 1 week ago

@FedericoTartarini I am afraid this is a copy-past error from the equation from the European version. I verified the source and it should be changed in R

FedericoTartarini commented 6 days ago

@LeylayqZhang could you please fix this in R?

LeylayqZhang commented 4 days ago

@LeylayqZhang could you please fix this in R?

done :)

FedericoTartarini commented 3 days ago

@LeylayqZhang thank you so much. Have you submitted a pull request to R? If so please close this issue.