search

CenterForTheBuiltEnvironment / pythermalcomfort

Package to calculate several thermal comfort indices (e.g. PMV, PPD, SET, adaptive) and convert physical variables.
https://pythermalcomfort.readthedocs.io/en/latest/
MIT License
140 stars 52 forks source link

PET calculator #27

Closed oylinv closed 2 years ago

oylinv commented 2 years ago

Hi there! I recently discovered the PET calculator, but it's written in javascript, and I'm new to javascript. Could you rewrite it and add it to Pythermalcomfort? If this is a problem, I'll try to turn it into a Python program, and I'll contact you!

FedericoTartarini commented 2 years ago

Hi @oylinv thank you very much for the valuable suggestion, rewriting the code into Python is not a difficult task I can do that.

On the other hand, before adding it to pythermalcomfort I need to make sure that the JS source code has been previously validated and it does not contains errors. Could you please help me find the Standard/paper which describes this code and the relative tables that need to be used to validate the function's output?

oylinv commented 2 years ago

Thanks! It's like there's no original paper in the JS code，but I found two ways to verify the function output. The first method uses Rayman app:

image

The second method gives a verification table： image

FedericoTartarini commented 2 years ago

Do you know if the Rayman code is also publicly available?

FedericoTartarini commented 2 years ago

I also found this Python code to calculate the PET. I have contacted the author and asked him if I can include it inside pythermalcomfort.

FedericoTartarini commented 2 years ago

Hi, @oylinv I have just released a new version of pythermalcomfort v2.1 which includes the PET model. Thank you so much for your suggestion.