Fix issues (2023-05-05)

AkihisaNomoto commented 1 year ago

Thank you for checking the code. I fixed the issues from #45 to #55. Please review each commit and comment on the issue. Let's work on #56 together later.

Thanks, Aki

codecov-commenter commented 1 year ago

Codecov Report

Merging #57 (687a47c) into master (ed25119) will increase coverage by 1.08%. The diff coverage is 29.54%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   47.44%   48.53%   +1.08%     
==========================================
  Files          14       15       +1     
  Lines        2664     2666       +2     
  Branches      404      406       +2     
==========================================
+ Hits         1264     1294      +30     
+ Misses       1345     1316      -29     
- Partials       55       56       +1

Impacted Files	Coverage Δ
...rc/pythermalcomfort/jos3_functions/construction.py	`9.67% <0.00%> (ø)`
src/pythermalcomfort/jos3_functions/parameters.py	`21.05% <ø> (ø)`
src/pythermalcomfort/models.py	`57.96% <2.94%> (-0.06%)`	:arrow_down:
...ythermalcomfort/jos3_functions/thermoregulation.py	`16.84% <27.39%> (+5.45%)`	:arrow_up:
src/pythermalcomfort/jos3_functions/matrix.py	`24.02% <28.57%> (+1.45%)`	:arrow_up:
tests/test_jos3.py	`100.00% <100.00%> (ø)`

FedericoTartarini commented 1 year ago

Thank you so much for working on this and fixing most of the issues I have opened. I have merged your pull request and closed most of the issues. We can discuss this week how to write some testing.

CenterForTheBuiltEnvironment / pythermalcomfort

Fix issues (2023-05-05) #57

Codecov Report