CenterForTheBuiltEnvironment / pythermalcomfort

Package to calculate several thermal comfort indices (e.g. PMV, PPD, SET, adaptive) and convert physical variables.
https://pythermalcomfort.readthedocs.io/en/latest/
MIT License
134 stars 49 forks source link

PMV ASHRAE results CBE Comfort Tool and pythermalcomfort do not match for V=0.1m/s #74

Closed FedericoTartarini closed 9 months ago

FedericoTartarini commented 9 months ago

Describe the bug The results from the two tools do not match for the following condition. I think the cause of the issue is the CE calculation since I get an error in pythermalcomfort saying that the cooling effect could not be calculated.

from pythermalcomfort.models import pmv_ppd, cooling_effect
from pythermalcomfort.utilities import v_relative, clo_dynamic
tdb = 19.6
tr = 19.6
rh = 86
v = 0.1
met = 1.1
clo = 1
# calculate relative air speed
v_r = v_relative(v=v, met=met)
print(v_r)
# calculate dynamic clothing
clo_d = clo_dynamic(clo=clo, met=met, standard="ashrae")
print(clo_d)
ce = cooling_effect(tdb=tdb, tr=tr, vr=v_r, rh=rh, met=met, clo=clo)
print(ce)
print(tdb, tr, v_r, rh, met, clo_d)
results = pmv_ppd(tdb=tdb, tr=tr, vr=v_r, rh=rh, met=met, clo=clo_d, standard="ashrae")
print(results)
print(results["pmv"])

Screenshots The result of pythermalcomfort is:

/Users/ftar3919/.local/share/virtualenvs/paper-pmv-comparison-reEzWohP/lib/python3.10/site-packages/pythermalcomfort/models.py:159: UserWarning: Assuming cooling effect = 0 since it could not be calculated for this set of inputs tdb=19.6, tr=19.6, rh=86, vr=0.13, clo=1.0, met=1.1
  warnings.warn(
{'pmv': -0.56, 'ppd': 11.6}
-0.56
image
FedericoTartarini commented 9 months ago

The error was in the CBE thermal comfort tool. I fixed the error in version 2.5.3