search

Centias / BankItems

Keep track of you inventory, bank, reagant bank, void storage and more across all your characters. Fork of the original BankItems on Curse/WowAce. Credit to XinHuan/Burstroc and anyone else who worked on the original.
26 stars 2 forks source link

Items equipped in profession slots not stored/counted #8

Closed GTSavvy closed 1 year ago

GTSavvy commented 1 year ago

Items equipped in Profession slots do not get counted by Bank Items

image

but they are seen/counted if you move it into your bag.

image

There is also no place to check these in the BankItems pane. Perhaps the "Equipped Items" (bag 100) should be updated to include them?

Will probably need to check what kind of event occurs when these items are equipped/unequipped to make sure they get updated properly by the addon.

Centias commented 1 year ago

I noticed the same when I was trying to check if some needed to be upgraded, though I'm not sure what slots these are yet.

Centias commented 1 year ago

Turns out the slots for these are basically exactly what you would expect (20-28) and saved pretty easily.

GTSavvy commented 1 year ago

Confirmed that profession items show up in tooltip and BankItems window under "Equipped Items" now, but there's a bug. If you hover over an empty spot, it throws a lua error:

image

Seems we need to add these as inventory slots to BANKITEMS_INVSLOT:

https://wowpedia.fandom.com/wiki/InventorySlotId

Have a possible local fix, and working on a Pull Request for this.

GTSavvy commented 1 year ago

Merge request seems to work when hovering over empty profession slots now. Unsure if the extra unused fishing slots will be an issue in the future since the Equipped Item bag doesn't show enough slots for them.

image

I also didn't add the texture for the empty profession slots (like you can see on the empty shirt slot) so some other potential rooms to improve.

Centias commented 1 year ago

Good catch. I brought it in and replaced the zip file in the last release.