CentralAZ / Rock-CentralAZ

An open source CMS, Relationship Management System (RMS), Church Management System (ChMS), and composable application framework.
http://www.rockrms.com
17 stars 3 forks source link

Approval/Deny status changes when it shouldn't #129

Open timlem opened 5 years ago

timlem commented 5 years ago

Prerequisites

Description

If a user (let's say Tom) opens a reservation page and Room B is unapproved and a new user opens the page after Tom (let's say Tim) and approves Room B and then Tom clicks edit and changes something else, it will unapprove Room B because when Tom clicked edit on their page that still had the room b listed as unapproved.

Please note I could not test this on demo site since I can't install plugins there.

Steps to Reproduce

  1. User A open a reservation request that has two resources requesting approval but does not click edit yet.
  2. User B opens the same request and clicks edit and approves resource A and hits save.
  3. User A now clicks edit and approves resources B and hits save.
  4. If you look at the history you'll see User A approved resource B and denied resource A.

Expected behavior:

When user A hits save it should only approve resource B and leave resource A alone.

Actual behavior:

When user A hits save it changes resource A because it was like that on the page when user A hit edit.

Versions

timlem commented 5 years ago

Screen Shot 2019-09-15 at 11 37 18 AM

tcavaletto commented 4 years ago

Approval/Deny status changes when it shouldn't