[RR] When an approved reservation is updated

[BEGamache]

Prerequisites

• [ ] Put an X between the brackets on this line if you have done all of the following:
  • Can you reproduce the problem on a fresh install or the demo site?
  • Did you include your Rock version number and client culture setting?
  • Did you perform a cursory search to see if your bug or enhancement is already reported?

Description

This may be more of an enhancement than a bug but when an approved reservation is updated/modified, if there is a final approval group set, can the reservation's approval state be switched back to Pending Review or Unapproved in order to require final approval again?

Right now a user can submitted a reservation and it can be fully approved by the final approval group. Once it is approved though, the user can go back into their reservation and modify their locations, dates and times, and resources (as long as none of these require additional approval) and when they save their edits their reservation will remain approved.

If a location or resource requires separate approval first the reservation is changed to Unapproved but I think this should be the broader default behavior for any approved reservation being modified.

Steps to Reproduce

1. Create a new reservation as a normal staff user.
2. As a user in the final approval group, approve the reservation
3. Go back as the normal staff user and edit the approved reservation. Change the date, time, location and resources--so long as these don't require their own separate approval.
4. The reservation will remain approved on saving the edits.

Expected behavior:

Reservation's approval state changed to Pending Review or Unapproved.

Actual behavior:

Remains approved.

Versions

Room Management: 1.4.1

• Rock Version: 9.2
• Client Culture Setting: en-US

[daniellevos]

We are experiencing the same issue with events not unapproving. It's been really frustrating for our staff.

[BEGamache]

I was able to get the 'Reservation Updated' trigger to run a workflow that changes the approval state back to Pending Review but I still need to tweak it so that it only runs when the reservation is approved and the user doing the modifying isn't in the final approver group. So if you need to, you can accomplish this in a workflow with the Reservation Updated trigger but it would be better if the block automatically handled changing the approval state back to Unapproved or Pending Review.

[megilee]

This is definitely a big need for us, too. @BEGamache, can you share the WF modification you made?

[tcavaletto]

When an approved reservation is updated, switch approval to Pending Review