CentralAZ / Rock-CentralAZ

An open source CMS, Relationship Management System (RMS), Church Management System (ChMS), and composable application framework.
http://www.rockrms.com
17 stars 3 forks source link

[RR] Reservation Type Attribute Security #165

Open TheArkChurch opened 4 years ago

TheArkChurch commented 4 years ago

Feature Request

Describe the Feature Request Room Reservation Type Reservation Attributes should Inherit the security of the reservation type, or the Room Administrator should be able to edit the Security of the attribute after the first save.

When a person designated as a Room Management Administrator adds Reservation Attributes to be asked as part of a reservation, by default(presumably because it's an actual entity attribute and not part of the reservation model), the permissions on the attribute don't let people see them, unless they are a rock administrator. This requires a Rock administrator to go to the entity attributes page and change the security of each question that was added so it's able to be edited by a staff worker when making a request.

Describe Preferred Solution Preferably any attributes created should inherit the security of the reservation type so that whoever can see and edit(necessary to even create a reservation) a reservation will also see the attributes without having to get a rock admin involved to turn on the correct permissions.

Describe Alternatives If inheritance isn't easily done, at least add a security button to the Reservation Type Configuration so that you can go to the Reservation Type and edit the attribute security from within that block. I have done this in our system and it's much easier than having to filter through the entity attributes page to find the exact attributes you need to edit the security of.

Providing Code I can provide code for the alternative method if needed but honestly, the preferred solution would be the better way to go as it's less work on the rock administrator. Additionally, it seems right that the attribute of something should inherit the parents security unless it's somehow undesired for other security reasons.

leahjennings commented 4 years ago

Just ran into this issue as well, quite confusing until I found the issue reported + workaround in the chat. One possible solution, at least in the short-term, could be to update the documentation to reflect the extra step (editing security under Security Settings > Entity Attributes) until that can natively occur.

tcavaletto commented 3 years ago

Reservation Type Attribute Security