People Receive Emails after upgrading

CentralAZ / Rock-CentralAZ

An open source CMS, Relationship Management System (RMS), Church Management System (ChMS), and composable application framework.

http://www.rockrms.com

17 stars 3 forks source link

People Receive Emails after upgrading #168

Closed tcavaletto closed 4 years ago

tcavaletto commented 4 years ago

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:
- Can you reproduce the problem on a fresh install or the demo site?
- Did you include your Rock version number and client culture setting?
- Did you perform a cursory search to see if your bug or enhancement is already reported?

Description

A clear and concise description of what the bug is, include screenshots if applicable.

Steps to Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior:

A clear and concise description of what you expected to happen.

Actual behavior:

A description of what actually happened.

Versions

Rock Version: [Enter Rock version here]
Client Culture Setting: [Enter Client Culture here]

marcierempel commented 4 years ago

This happened to us as well. It took past reservations (looks like almost all of them going back to when we installed the plugin) and changed the status on all of them back to Pending Review - that means that everyone received a notification and we have to go back and approve all of them - which means everyone will receive another email.

tcavaletto commented 4 years ago

@marcierempel Could you give me a screenshot of the history on one of these reservations? I'll be digging into this issue this weekend and a reference point would be extremely helpful.

marcierempel commented 4 years ago

Room Reservation status change

I wondered if it had something to do with the Populate FirstOccurrenceStartDateTime and LastOccurrenceEndDateTime fields on the Reservation table - job that ran. I don't remember seeing that job before the update to 1.5.2.

It changed the statuses on over 750 reservations, but I'm having a hard time determining if it was only reservations that were approved already. It doesn't look like it touched any that had been denied. I'm trying to figure out a way to get all of them back in to the correct status.

marcierempel commented 4 years ago

Room Reservation status change2

tcavaletto commented 4 years ago

This issue is now resolved and will be rolled into the next update.

tcavaletto commented 4 years ago

@marcierempel ++ for nailing where the source of the problem was.

marcierempel commented 4 years ago

@tcavaletto Do you know if it only changed the status of approved reservations back to pending review or did it change all reservations despite their current status? we're trying to figure out a way to get everyone of them back to what their status was before the job ran.