[RR] - v1.5.5 - Making a Reservation View inactive doesn't remove it from the View As dropdown menu

[leahjennings]

Prerequisites

• [X] Put an X between the brackets on this line if you have done all of the following:
  • Can you reproduce the problem on a fresh install or the demo site?
  • Did you include your Rock version number and client culture setting?
  • Did you perform a cursory search to see if your bug or enhancement is already reported?

Description

When you mark a reservation view inactive under Room Management > Admin Tools > Reservation Views, it doesn't remove it from the "View As" dropdown menu on the primary Room Management page. There's a view we added that we want to keep the code for but don't want people to use, marking it inactive I would think would remove it from that dropdown menu, however the dropdown menu seems to be pulling all reservation views whether or not they are active.

Steps to Reproduce

1. Go to Room Management > Admin Tools > Reservation Views
2. Select any reservation view and mark it inactive
3. 
4. Go back to Room Management
5. The View As dropdown shows all reservation views, even the ones that are inactive
6. 

Expected behavior:

The View As dropdown menu would only show the reservation views that are active.

Actual behavior:

The View As dropdown menu shows all reservation views, whether or not they are active.

Versions

• Rock Version: [Rock McKinley 11.2 (1.11.2.1)]
• Client Culture Setting: [en-US]