CentralValleyModeling / wrims

5 stars 3 forks source link

WRIMS GUI Menu Item Data->Load Dss/Study with mix of DSS 6/7 files #111

Open rma-tom opened 2 months ago

rma-tom commented 2 months ago

This menu item is used when you debug the model by running the model as “debug as” and pause the model in the middle of the run. It is basically to load the selected dss files to make comparisons in the Variables and Watch View on the right hand side.

In tests, Data->Load Dss/Study function works only if the loaded SV and DV DSS files are version 6. Have not yet tested with both files version 7. This suggests that the problem may be with the 6/7 differences in the path parts: “c_kswck” vs. “C_KSWK” and "1MON" vs. "1Month" for example.

rma-tom commented 2 months ago

Notes transferred from emails and discussion: Hao: The problem of loading dss for comparison function not working might be related to mix reading HecLib 6 and 7 dss. In the test case we have, dv file to load for comparison is HecLib 7 dss but sv file is HecLib 6 dss.

When loading them together, I don’t know how HecLib 7 will distinguish the difference. I hope to have the code in WRIMS to detect which version the dss file is and then read the dss accordingly.

Tom: Have we (or HEC) developed a bit of code that will find both of those appropriately in 6 or 7 files, if asked to search for either of those paths? That seems like a generally useful thing.

Hao: What I found is HecLib7 can load both v6 or both v7 dss files with our current code but gets confused when v6 and v7 loaded together. If v6 and v7 are read in this sequence, only v6 gets read but v7 fails, vice verse.

The same goes to the report tool. We have to have the code to make HecLib 7 recognize which version is the dss file first and then read the file accordingly. …

hxiedwr commented 2 months ago

I think both v7 files to be loaded should work. The status of Report Tool can support my thinking. Report tool is able to compare two v6 dv files or two v7 dv files, but not one v6 and one v7 dv file. I think in one thread, HecLib 7 is set to read one version of dss file, which doesn’t work in our cases. WRIMS should be able to switch the version in one thread when it reads multiple dss files.


From: Tom Evans @.> Sent: Friday, August 23, 2024 10:38:20 AM To: CentralValleyModeling/wrims @.> Cc: Xie, @. @.>; Assign @.***> Subject: Re: [CentralValleyModeling/wrims] WRIMS GUI Menu Item Data->Load Dss/Study with mix of DSS 6/7 files (Issue #111)

Assigned #111https://github.com/CentralValleyModeling/wrims/issues/111 to @hxiedwrhttps://github.com/hxiedwr.

— Reply to this email directly, view it on GitHubhttps://github.com/CentralValleyModeling/wrims/issues/111#event-13996109023, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC7C7KRATVZ6QCGJA3J5V5DZS5XQZAVCNFSM6AAAAABNASCVVWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE4TMMJQHEYDEMY. You are receiving this because you were assigned.Message ID: @.***>