search

CentreForDigitalHumanities / lidia-zotero

Zotero plugin for capturing PDF reader annotations for the LIDIA project
https://lidia.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Zotero 7 #52

Closed ar-jan closed 11 months ago

ar-jan commented 1 year ago

Try running with Zotero 7.

ar-jan commented 1 year ago

Varous observed errors, apparently unrelated:

addons.xpi WARN Not converting unknown addon type undefined [JavaScript Error: "Error: Cannot find loader for bootstrap" {file: "resource://gre/modules/addons/XPIProvider.jsm" line: 1920}] [JavaScript Error: "Error: Addon must include an id, version, and type" {file: "resource://gre/modules/addons/XPIProvider.jsm" line: 1710}]

addons.xpi WARN Addon with ID undefined already installed, older version will be disabled

When installing xpi instead of running from build dir:

addons.xpi-utils WARN Add-on lidia-zotero@cdh.uu.nl is not compatible with application version. addons.xpi-utils WARN addMetadata: Add-on undefined is invalid: Error: Invalid addon ID: expected addon ID undefined, found undefined in manifest(resource://gre/modules/addons/XPIDatabase.jsm:2972:15) JS

ar-jan commented 1 year ago

The manifest.json looks fine, contains everything needed comparing with docs and make-it-red.

tijmenbaarda commented 11 months ago

72 and #71 have been fixed now. #73 has been fixed with a hack.

tijmenbaarda commented 11 months ago

Installing the XPI now works for me on Zotero 7 without problems. The extension also still works on Zotero 6 (and also when installing from the XPI). So I think this pull request is ready for merging.