search

CentreForDigitalHumanities / tscan

T-scan: an analysis tool for dutch texts to assess the complexity of the text, based on original work by Rogier Kraf
GNU Affero General Public License v3.0
18 stars 6 forks source link

Fork diverges from upstream #61

Closed proycon closed 1 year ago

proycon commented 2 years ago

I just noticed this tscan fork and see that it is ahead of 'my' version by quite a number of commits (which is a good thing, glad to see it's still being worked on!). I was wondering what the current status of this project and this particular fork is? I haven't received any pull requests from you guys so the work you've been doing does not land in the upstream releases nor the version shipped in LaMachine. That might be a bit confusing to users as it makes your improvements less accessible, same for having two issue trackers.

I'm not really a t-scan maintainer nowadays (nor have I been for a long time, @mhkuu already was the maintainer for years) and it's mostly under my account for historical reasons. So to remedy the problem of there being 'two tscans' I'd be open to just transferring my tscan repository to you guys if you're interested in maintaining it. Then you guys have all control (and the responsibility to do proper releases whenever you see fit of course, those are needed for proper distribution & deployment like via LaMachine).

(When transferring repos, github will simply redirect from the old link to the new one, so it shouldn't break anybody's workflow as long as it's the same git tree. We'd have to work out how to make sure the issues merge properly though)

oktaal commented 2 years ago

Sorry for my late reply! We'd be happy to take over you repo. I've just checked to see if there aren't any merge conflicts anymore. (which was only a slightly older version of the manual)

A workaround for transferring the issues could be that we temporary grant you permission to create a project in the lab, and rename our fork of tscan. You could then transfer it to our organisation and we could merge all our issues and changes into this repo.

proycon commented 2 years ago

A workaround for transferring the issues could be that we temporary grant you permission to create a project in the lab, and rename our fork of tscan. You could then transfer it to our organisation and we could merge all our issues and changes into this repo.

That sounds like a good procedure yes

@mhkuu Do you also agree with this transfer? You'll have direct access here too right?

mhkuu commented 2 years ago

Yes, sounds great! :+1: I'm looking forward to giving T-Scan a spin again with all these new features! :rocket:

proycon commented 2 years ago

@oktaal Sorry for the delay! Let's do this asap. Perhaps we should arrange some time where we're both online and available so we can can coordinate the transfer 'live' and fix anything that might arise?