search

CentroEPiaggio / kuka-lwr

Software related to the KUKA LWR 4+: for real and for simulation.
The Unlicense
101 stars 81 forks source link

Updated Travis file #70

Closed felixduvallet closed 8 years ago

felixduvallet commented 8 years ago

Hi-

I came across this repository and noticed some of your builds were erroring (e.g, https://travis-ci.org/CentroEPiaggio/kuka-lwr/builds/114792409).

Feel free to use this .travis.yml file if you'd like. It works on the master branch (https://travis-ci.org/felixduvallet/kuka-lwr/builds/121359321) but let me know if you have any issues merging this into feature branches.

There's documentation available here: http://felixduvallet.github.io/ros-travis-integration/

Cheers, Felix

carlosjoserg commented 8 years ago

Thanks @felixduvallet , it looks a very complete script you propose. Some reasons why the travis script is as it is right now.

I prefer to keep this file as simple as possible (i.e. avoid as possible the use of variables $$), since I always point at it as "basic install instructions".

I prefer the branching-by-feature instead of branching-by-release (ROS distro-wise), so I don't see the point of having that in a variable here: https://github.com/CentroEPiaggio/kuka-lwr/pull/70/commits/02126feebb794d979e3397a9b02dacdf36bf0820#diff-354f30a63fb0907d4ad57269548329e3R56

I would also like to keep the white-list for the master branch build, because only that one should be compiling-safe. Personally, I don't care about experimental branches not compiling https://github.com/CentroEPiaggio/kuka-lwr/pull/70/commits/02126feebb794d979e3397a9b02dacdf36bf0820#diff-354f30a63fb0907d4ad57269548329e3L11

I think that error was because the PR was using branches different from master, were the travis file is out of date. I believe the one in the master branch is fine.

Thanks for you suggestions at any case.

felixduvallet commented 8 years ago

No worries, it'll be there if you change your mind :)