CentroEPiaggio / kuka-lwr

Software related to the KUKA LWR 4+: for real and for simulation.
The Unlicense
101 stars 81 forks source link

Missing moveit_planning_execution.launch #83

Closed marcoesposito1988 closed 7 years ago

marcoesposito1988 commented 7 years ago

The file was added in cee59d494bf7afe5eda331fbf9cae00a4b4b792f, but I can't find it any more in master.

Was it devoured by some git merge?

carlosjoserg commented 7 years ago

Hi @marcoesposito1988 Yep, I see it was out in #18, but I don't think on purpose, too many changes in that PR, feel free to add it again, and my apologies !

marcoesposito1988 commented 7 years ago

I thought so :rofl: no problem, I will make a pull request to put it back

marcoesposito1988 commented 7 years ago

BTW: in the current RViz configuration, the planning request marker size is set to zero. This means, that you can't see the marker to command the robot. This can be EXTREMELY confusing for a newbie just trying out the package (I think I spent half an hour figuring this out myself, including recompiling RViz!)

Would you mind if I add another RViz config file to be loaded by moveit_planning_execution.launch? This way your setup would not change, but new users would be not as confused.

marcoesposito1988 commented 7 years ago

Fixed by #88