Review fixes - Githubissues

CenturyLinkCloud / Cyclops

The UX/UI Pattern Guide for the CenturyLink Platform

http://assets.ctl.io/cyclops

MIT License

20 stars 16 forks source link

Review fixes #142

Closed pascualin closed 7 years ago

pascualin commented 7 years ago

This PR only solves the following issues:

Make Cyclops pages show the default menu
Make Cyclops Navigation Bar 64px height
Fix issue with CenturyLink logo on the top right part of the page

More fixes on the next PR

jsmecham commented 7 years ago

Not sure if you intended this to be reviewed yet, but just noticed that it causes overlapping with the main menu:

screenshot

This can be fixed by updating https://github.com/CenturyLinkCloud/Cyclops/blob/master/src/scripts/models/mainNavViewModel.coffee#L94. It's ugly hardcoding there (also what my flexbox branch was supposed to fix).

pascualin commented 7 years ago

Good call, looking at it now,

Thanks!

pascualin commented 7 years ago

@mattnickles Please review

jsmecham commented 7 years ago

I've addressed your comments, I believe. The things under "Few things missing." are addressed in a separate PR at https://github.com/CenturyLinkCloud/dt-GlobalNavigationMenu/pull/4.

pascualin commented 7 years ago

Ey @mattnickles. Could you please review the latest changes on this PR. This fixes the issues with the Open Sans font on Cyclops among many other issues.

pascualin commented 7 years ago

@mattnickles The two issues have now been solved. Please check.