CenturyLinkCloud / Cyclops

The UX/UI Pattern Guide for the CenturyLink Platform
http://assets.ctl.io/cyclops
MIT License
20 stars 16 forks source link

Account and support menus broken on narrow viewports #155

Open guyaparker opened 6 years ago

guyaparker commented 6 years ago

The account and support menus render badly on narrow viewports and some links become unclickable. They worked on the 1.8.3 sample pages (e.g. http://assets.ctl.io/cyclops/1.8.3/starterPages/basic.html):

screen shot 2018-03-26 at 12 09 35

But are broken on 1.8.4 (e.g. http://assets.ctl.io/cyclops/1.8.4/starterPages/basic.html)::

screen shot 2018-03-26 at 12 13 16

I've tried sample page tests with and without the GlobalNavMenu included and believe the issue is related to changes in Cyclops for the GlobalNavMenu rather than the GlobalNavMenu causing the issues.

These changes seem to be involved: https://github.com/CenturyLinkCloud/Cyclops/commit/c62ed555bdc11f879082a8c528d6b2d15a387601#diff-11f7153e01dbe9d55a1908a075d9326a https://github.com/CenturyLinkCloud/Cyclops/commit/12dd14397d83bb99aa7e8004b518a03e4b890feb#diff-11f7153e01dbe9d55a1908a075d9326a

When the GlobalNavMenu includes a support menu the issue becomes even worse:

screen shot 2018-03-26 at 12 21 51

guyaparker commented 6 years ago

I think these over rides fix it:

@media (max-width: 991px) { global-menu-support .items-list { right: auto !important; } global-menu-support .arrow { right: auto !important; left:24px !important; } html.cyclops .dropdown .dropdown-menu.dropdown-menu-right { right: auto; left: 0; } html.cyclops .navbar-static-top .open .dropdown-menu { position: absolute; background-color: #fff; border: 1px solid #d5d5d5; box-shadow: 0 2px 8px rgba(24,26,30,.2); } }

screen shot 2018-03-26 at 14 26 04

aryaroudi commented 5 years ago

175 Hey @guyaparker I guess this PR will fix your issue