CenturyLinkCloud / clc-java-sdk

Apache License 2.0
6 stars 4 forks source link

Rename variables that contains password #125

Closed idrabenia closed 9 years ago

idrabenia commented 9 years ago

There was a critical violation in PropertiesFileCredentialsProvider.java because PASSWORD_KEY was tripping the rule about hardcoding passwords. I'd like to find a different name for this variable so that it doesn't trip the rule. If you rename it to something that doesn't match the regex "password" it should close the issue. E.g: "PASS_KEY" or "PASSWD_KEY". I know this seems minor, but it's one less thing we have to explain if a customer scans it.

pslam commented 9 years ago

done within https://github.com/CenturyLinkCloud/clc-java-sdk/commit/1d0487f8e74c306141904b00d6655a5c4c3b29ea

idrabenia commented 9 years ago

Thanks! Could you also see our sonar tickets for this issue - http://66.155.4.208:9000/dashboard/index/1 and improve code places provided by sonar.

pslam commented 9 years ago

np

pslam commented 9 years ago

done