CenturyLinkCloud / clc-java-sdk

Apache License 2.0
6 stars 4 forks source link

Refactor string comparison to use yoda notation #126

Closed idrabenia closed 9 years ago

idrabenia commented 9 years ago

We really need to use yoda notation for string comparisons when checking against string literals. Please move the string literals to the left side of the comparison. It’s a best practice in Java to avoid Null Pointer Exceptions. This happens in a number of files: GroupMetadata.java L393; BaseServerResponse.java L70, 81; ServerFilter.java L262;PauseServerJobFuture.java L47; SuperCommandSampleApp.java L166.

pslam commented 9 years ago

Done, but PauseServerJobFuture couldn't find

idrabenia commented 9 years ago

Awesome! Unfortunatelly after code modification we started to have such issues in any other places. Could you also see our sonar tickets - http://66.155.4.208:9000/dashboard/index/1 and improve this issue in provided by it places.

Thanks!

pslam commented 9 years ago

done

idrabenia commented 9 years ago

Good Job!