search

CenturyLinkCloud / clc-java-sdk

Apache License 2.0
6 stars 4 forks source link

Policies Design Issue #189

Closed idrabenia closed 8 years ago

idrabenia commented 8 years ago

Hi @jruckle @brianalbrecht @markramach ,

I think now we have bug in design of our SDK - current structure:

- sdk
    - loadbalancer.services
    - policy.services
    - server.services (including network management)

I propose to remove policy.services submodule and move it's functionality to server services (because this functionality highly coupled with servers).

But this changes will break backward compatibility

  1. Are you agreed with this refactoring - policy.services we will move to server.services?
  2. Will it be a big issue - if we will release this changes in next SDK version and significantly change API?

Thanks, Ilya

idrabenia commented 8 years ago

@jruckle yes, our API in some places provide not unified UX and we will have possibilities to improve it by this refactoring.

For instance it would be possible to make Network references API, Policy services API more user friendly.

Not a problem - current policies design and API is also acceptable but it's wrong in terms of classical design principles, may increase count of bugs in future and will surprise any users.

Yes, we may delay this refactoring until next version. But if we have possibilities to eliminate this issue now - it would be great.

Thanks for quick response :)