Closed chiefy closed 8 years ago
I can confirm that this fixes my problem (issue 14).
If this defaults to writing to bin
instead of the root of the source path, I think it's going to break existing users who are used to the way it works out of the box. Like my CI. :smile:
Maybe instead of OUTDIR
, you can just override the whole path altogether? Then you can do whatever you want, make it bin/vault
or nonconflicting-vault
, etc.
testing-the-ground-with-one-toe-vault...
@dpetersen where should we put the compiled binary? typically it would go in $GOPATH/bin
right?
I should've added some docs too. Sorry.
@chiefy it's $GOPATH/bin
when you go get
something, but generally a go build
will just drop the binary in the same directory you're in as far as I know. The golang-builder seems analogous to a go build
.
Either way, the current implementation drops the binary in the source directory. If we change that default it's going to break any setup that depended on the current default location of the build binary. I do like the idea of being able to customize the location and name of the binary for cases where the default doesn't work, like vault.
@dpetersen I refactored it a bit, added some docs and rebased. Your CI looks like it isn't setup right?
I don't know what circle's deal is. As far as I know it was never set up to run on this project at all.
So I don't have merge rights on this repository. The Labs team does not actually exist anymore, though some of us do have the ability to merge here. @bdehamer, does this look good to you? It looks good to me.
@dpetersen @bdehamer Can you please merge @chiefy 's changes? I am hitting the same issue while trying to create vault container.
ping @dpetersen @bdehamer LGTM :thought_balloon: ?
-o
switch togo build
to allow custom binary location