crosserclaws commented 7 years ago

除了小修正外，新增 2 個 package。 common/backend_pool : 由 api, gateway, transfer 使用的 connection pool common/sdk : 由 aggregator, nodata 使用，與 API 模組進行互動。

falcon-plus v0.2.1 commit hash: 9071ef2dc620cd82b6b8854df3dd66aebedcd5f5

codecov-io commented 7 years ago

Codecov Report

Merging #388 into develop will increase coverage by 0.37%. The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #388      +/-   ##
===========================================
+ Coverage    40.57%   40.94%   +0.37%     
===========================================
  Files          228      228              
  Lines        14887    14999     +112     
===========================================
+ Hits          6041     6142     +101     
- Misses        8536     8545       +9     
- Partials       310      312       +2

Impacted Files	Coverage Δ
common/model/host.go	`0% <0%> (ø)`	:arrow_up:
common/utils/map.go	`67.64% <0%> (-2.05%)`	:arrow_down:
common/testing/flag/flag.go	`85.47% <0%> (+3.72%)`	:arrow_up:
common/service/mysql_api.go	`89.28% <0%> (+5.28%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff10047...90d39ac. Read the comment docs.

hitripod commented 7 years ago

把 merge 的 latest commit hash 補上於 PR 描述

crosserclaws commented 7 years ago

補上 commit hash & 修正錯誤的 import package

crosserclaws commented 7 years ago

團隊共識為先暫緩 v0.2.1 合併相關的工作，先 close。

Cepave / open-falcon-backend

[OWL-1984] Merge common module of falcon-plus v0.2.1 #388

Codecov Report