search

CephalofairGames / frosthaven-faq

https://cephalofairgames.github.io/frosthaven-faq/
MIT License
12 stars 2 forks source link

clarify negative item effects wording #16

Closed benknoble closed 1 month ago

benknoble commented 1 month ago

The original reads as though the choice not to equip is dependent on not having the relevant perk, which is not the intended meaning. It also reads as though gaining the -1s are required if you equip the item, which is also not quite the intended meaning (since those -1s are avoided by having the perk!).

Instead, note that you can always choose not to equip an item. Adding the -1s is contingent on equipping the item sans relevant perk.

dwarf74 commented 1 month ago

I think I will open this as an Issue instead of a Pull request.

benknoble commented 1 month ago

@dwarf74 Why as an issue? The pull request includes my suggested changes to clarify the wording, not just a description of the problem.

PS I'm happy to answer any questions about Git you might have. I run a lot of training for it. I also recommend https://git-scm.com and the free Pro Git book linked there if you haven't already seen it.

dwarf74 commented 1 month ago

Yeah basically because I am new at this :) And also made a large batch of changes tonight.

No offense intended.

dwarf74 commented 1 month ago

Merged, thank you for the help!

benknoble commented 1 month ago

No worries! Glad it worked out.