Cercain / ImprovedCommandEssence

An RoR2 mod to balance the Command Artifact
1 stars 0 forks source link

Incompatibility issue with Starstorm 2 #13

Closed Apaples closed 2 months ago

Apaples commented 1 year ago

I'm hoping you'd be willing to help me with getting your mod to work with Starstorm 2. There is a bug when both mods are installed where Green Essence that come from defeating the teleporter event boss include these invalid White box choices.

Startstorm2

If you select one, it does spawn in the world. It is invisible but a prompt exists that says "Pick Up ???" Pressing the interact key does not pick anything up.

This issue does not occur with most Green Essences , only those dropped by bosses. A boss Green will randomly have an amount of these white boxes. Rarely having all regular items, often having 1 or 2 white boxes, and occasionally having only white boxes as choices.

I'm not sure which mod is at 'fault' for this incompatibility. I have hunches on what might be causing it, but as a complete novice, I doubt they'd be very useful.

If you're willing to look into this, I would appreciate it. I'm happy to help in any way I can. You can contact me via discord. @ apples#1807. I am in the modding discord and have open PMs

Apaples commented 1 year ago

Changing SameBossDrop to False Bypasses this issue. So, perhaps something in your code that ensures the boss drops are the same causes the problem. I don't know if other new item mods cause this same issue.

Darkmega18 commented 1 year ago

ah. so this can be fixed with a config? wonderful.

Cercain commented 2 months ago

Hey, sorry for such a late response, finally catching up on these.

Were you able to figure this one out? When SameBossDrop is enabled I hook into the BossGroup.DropRewards event, if your mod is adding items to BossGroup.dropTable that could be where it is pulling those from

Cercain commented 2 months ago

I've not been able to replicate this, StarStorm 2 may have fixed the issue causing this?

Cercain commented 2 months ago

ah nvm was able to repro

Cercain commented 2 months ago

fixed in 1.3.3