Cercain / ImprovedCommandEssence

An RoR2 mod to balance the Command Artifact
1 stars 0 forks source link

Mod disables artifact of delusion #17

Closed kg-csl closed 1 month ago

kg-csl commented 1 month ago

With this mod active, the new delusion artifact does nothing. Is this intended?

Cercain commented 1 month ago

Can you check if this is the case with base Command?

kg-csl commented 1 month ago

Delusion is fine with base Command. It might be a certain setting though. I'll attach my config.


[ImprovedCommandEssence]

## Set the amount of Common (white) options shown when opening a Command Essences.
# Setting type: Int32
# Default value: 6
itemAmountCommon = 9

## Set the amount of Uncommon (Green) options shown when opening a Command Essences.
# Setting type: Int32
# Default value: 4
itemAmountUncommon = 9

## Set the amount of Legendary (Yellow) options shown when opening a Command Essences.
# Setting type: Int32
# Default value: 2
itemAmountLegendary = 6

## Set the amount of Yellow items shown when opening a Command Essences.
# Setting type: Int32
# Default value: 2
itemAmountBoss = 4

## Set the amount of Blue items shown when opening a Command Essences.
# Setting type: Int32
# Default value: 2
itemAmountLunar = 1000

## Set the amount of Blue items shown when opening a Command Essences.
# Setting type: Int32
# Default value: 2
itemAmountVoid = 1000

## Set the amount of Orange items shown when opening a Command Essences.
# Setting type: Int32
# Default value: 4
itemAmountEquip = 9

## Set the amount of items shown when opening a Void Potential from a Void Cache.
# Setting type: Int32
# Default value: 6
itemAmountPotential = 1000

## Set the amount of items shown when opening a Void Potential from a Void Triple.
# Setting type: Int32
# Default value: 4
itemAmountPotentialCache = 1000

## Set the chance for item drops to drop as a Command Essence (0-100) from non-explicit chests
# Setting type: Int32
# Default value: 100
essenceChance = 100

## Set if category chests only show items of the corresponding category.
# Setting type: Boolean
# Default value: true
keepCategory = false

## Set if the Command Artifact is turn on in the Bazaar.
# Setting type: Boolean
# Default value: false
onInBazaar = true

## Set if the Command Artifact is turn on for Drop Ship items.
# Setting type: Boolean
# Default value: false
onInDropShip = false

## Set if the Command Artifact is turn on for Adaptive Chest items.
# Setting type: Boolean
# Default value: false
onForAdaptive = true

## Set if the Command Artifact is turn on for Void Potentials and Void Caches.
# Setting type: Boolean
# Default value: false
onForPotential = true

## Set if the Command Essences that drop from the Teleporter boss give the same options.
# Setting type: Boolean
# Default value: true
sameBossDrops = true

## Set if the item dropped by bosses killed via Trophy Hunter's Tricorn drop as a Command Essence (true) or the boss item (false)
# Setting type: Boolean
# Default value: false
onForTrophy = false

## Set if Scrappers spawn
# Setting type: Boolean
# Default value: false
enableScrappers = true

## Set if Printers spawn (onInDropShip must be on to drop as the item)
# Setting type: Boolean
# Default value: false
enablePrinters = false

## Set if Multishops spawn (onInDropShip must be on to drop as the item)
# Setting type: Boolean
# Default value: false
enableTerminals = true

## Set if Scrappers drop scrap (false) or Command Essence (true)
# Setting type: Boolean
# Default value: false
scrappersDropEssence = true

## Add item names to make them drop as the item not an essence (Can be used to force compatability for other mods with set drops ie. 'ItemIndex.idSagesBook')(comma seperated)
# Setting type: String
# Default value: 
customCompatibility =
Cercain commented 1 month ago

Ok, I think I've found the issue, 1.2.4.4 changed an API I was hooking onto, so it now ignores the Delusion stuff they added, looking to add it back in but the community package doesnt have the new API added yet

kg-csl commented 1 month ago

Awesome, glad you found the issue. And it's fine that the package doesn't have the API yet because it really isn't that huge of a deal, people who use this mod are likely not using Delusion because it's so overpowered.

On Sun, Jun 2, 2024 at 8:18 PM Cercain @.***> wrote:

Ok, I think I've found the issue, 1.2.4.4 changed an API I was hooking onto, so it now ignores the Delusion stuff they added, looking to add it back in but the community package doesnt have the new API added yet

— Reply to this email directly, view it on GitHub https://github.com/Cercain/ImprovedCommandEssence/issues/17#issuecomment-2143788523, or unsubscribe https://github.com/notifications/unsubscribe-auth/BC3GNV63IQNRQ7EB45MHIDLZFLWO7AVCNFSM6AAAAABIUBQQ5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTG44DQNJSGM . You are receiving this because you authored the thread.Message ID: @.***>

Cercain commented 1 month ago

So I hadn't updated MMHOOK, got it all working now. will be fixed in 1.3.6 I'm uploading now

kg-csl commented 1 month ago

Amazing bug fixing service, thanks!

On Sun, Jun 2, 2024, 10:00 PM Cercain @.***> wrote:

So I hadn't updated MMHOOK, got it all working now. will be fixed in 1.3.6 I'm uploading now

— Reply to this email directly, view it on GitHub https://github.com/Cercain/ImprovedCommandEssence/issues/17#issuecomment-2143819474, or unsubscribe https://github.com/notifications/unsubscribe-auth/BC3GNV6RZKE5OW64A4BGGZTZFMCMXAVCNFSM6AAAAABIUBQQ5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHAYTSNBXGQ . You are receiving this because you authored the thread.Message ID: @.***>