search

Cercain / ImprovedCommandEssence

An RoR2 mod to balance the Command Artifact
1 stars 0 forks source link

The Items you get from completeing a Cell in the Void Field are broken #22

Closed Sanserio closed 4 months ago

Sanserio commented 5 months ago

When you select the dropped items you get from completeing a void cell it's straight up blank, you can't get it, it'd be great if there was an option to disable Command from affecting the item drops from those cells entierly so they can actually function

Cercain commented 5 months ago

I'm hoping to take a look into this this week

Sanserio commented 4 months ago

Thank you so muchh me and my friends can't wait we don't play ror2 without this mod anymore

Cercain commented 4 months ago

I've managed to get these working in 1.4.4. They now drop as the void potential they would have in with no artifact. It's not the solution I'd have liked, as I would prefer it to be affected by the configs of the mods, but the vanilla code handling this is very awkward.

I'm going to keep this issue open, and hopefully I can work a way to incorporate the configs to those drops.

khdtheryu commented 4 months ago

I just tested out 1.4.4 and the issue persists for me. Void potential drops, when you open it, there is only 1 blank item. When you click it, the void potential goes completely blank and you can no longer interact with it. Maybe I should change something in the config? I had no issues with void potentials prior to couple of mod updates I believe.

Cercain commented 4 months ago

Strange, it worked fine when I tested, what is your config?

khdtheryu commented 4 months ago

Attached txt version of my config ImprovedCommandEssence.txt

Cercain commented 4 months ago

I just completed all 9 cells successfully with your config, what other mods have you got?

Cercain commented 4 months ago

Ah ok, the cells complete, but the void triple chests that drop normal void potentials drop as you describe

Cercain commented 4 months ago

If you change the config value onForPotential to false, it should work to drop as a potential and use those config amounts. True should make it drop as a command essence, but that's currently bugged

khdtheryu commented 4 months ago

Okay, that will do for now, thank you. Hopefully you can find a way to fix this.

Cercain commented 4 months ago

I think I've found the issue, I changed the way that items are selected for the Command Essence in 1.4.2, and that new way conflicts with Void Potentials. I'll revert that and get another version pushed once I've confirmed thats a fix

Cercain commented 4 months ago

Pushed 1.4.5 which fixes this now. Thanks for raising this, this mod has got so big I really need to start a test plan for every release >.< Also reverted the half-fix for Cell rewards, as this actually addressed that too, so closing the issue now

Cercain commented 4 months ago

I prefer to play with onForPotential = false as the potentials have a mix of rarities, so this wouldnt have been caught with my regular testing play

khdtheryu commented 4 months ago

Glad to know I was somewhat of help. And thank you once again, for your mod and your time.